Add static code analysis with cppcheck
This commit is contained in:
@@ -108,12 +108,14 @@ int gpio_read(const struct gpio *gpio, unsigned int *value)
|
||||
int gpio_write(const struct gpio *gpio, unsigned int value)
|
||||
{
|
||||
int res;
|
||||
unsigned char mask = gpio->ftdi_dev->status_mask;
|
||||
unsigned char mask;
|
||||
|
||||
if(NULL == gpio) {
|
||||
return EXIT_FAILURE;
|
||||
}
|
||||
|
||||
mask = gpio->ftdi_dev->status_mask;
|
||||
|
||||
if(value == 0) {
|
||||
mask &= ~(unsigned char)(gpio->pin);
|
||||
}
|
||||
@@ -135,13 +137,13 @@ int gpio_write(const struct gpio *gpio, unsigned int value)
|
||||
int gpio_toggle(const struct gpio *gpio)
|
||||
{
|
||||
int res;
|
||||
unsigned char mask = gpio->ftdi_dev->status_mask;
|
||||
unsigned char mask;
|
||||
|
||||
if(NULL == gpio) {
|
||||
return EXIT_FAILURE;
|
||||
}
|
||||
|
||||
mask ^= (unsigned char)(gpio->pin);
|
||||
mask = (gpio->ftdi_dev->status_mask) ^ (unsigned char)(gpio->pin);
|
||||
|
||||
res = ftdi_write_data(gpio->ftdi_dev->ftdi, &mask, 1);
|
||||
if(res < 0) {
|
||||
|
Reference in New Issue
Block a user